Discussion:
Bug#1084781: pandas can't find new pydata-sphinx-theme
Add Reply
Rebecca N. Palmer
2024-10-08 07:00:01 UTC
Reply
Permalink
Package: python3-pydata-sphinx-theme,python-pandas-doc
Severity: serious

(Likely to be fixed in pandas, but filing this to block testing
migration in the meantime.)

pandas 2.2.3 built in Salsa with the old pydata-sphinx-theme, but failed
on the buildds with the new pydata-sphinx-theme, with an error message
that it was trying to open a file that doesn't exist (in either version,
so I'm not sure yet exactly what went wrong).

pandas currently has some explicit workarounds to build with the older
pydata-sphinx-theme that was then available, so removing those might be
enough, but might not.
Debian Bug Tracking System
2024-10-08 19:20:01 UTC
Reply
Permalink
retitle -1 pydata-sphinx-theme missing templates etc
Bug #1084781 [python3-pydata-sphinx-theme,python-pandas-doc] pandas can't find new pydata-sphinx-theme
Changed Bug title to 'pydata-sphinx-theme missing templates etc' from 'pandas can't find new pydata-sphinx-theme'.
reassign -1 python3-pydata-sphinx-theme
Bug #1084781 [python3-pydata-sphinx-theme,python-pandas-doc] pydata-sphinx-theme missing templates etc
Bug reassigned from package 'python3-pydata-sphinx-theme,python-pandas-doc' to 'python3-pydata-sphinx-theme'.
No longer marked as found in versions pydata-sphinx-theme/0.15.4+dfsg-1.
Ignoring request to alter fixed versions of bug #1084781 to the same values previously set
--
1084781: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1084781
Debian Bug Tracking System
Contact ***@bugs.debian.org with problems
Rebecca N. Palmer
2024-10-08 20:50:01 UTC
Reply
Permalink
That's not enough: it now can't find static/webpack-macros.html , which
doesn't exist as a file in the source.

https://salsa.debian.org/rnpalmer-guest/pydata-sphinx-theme/-/jobs/6398738

It looks like this file is supposed to be created by
sphinx-theme-builder, but that our patch might be disabling that and/or
our version of it might be too old.
Drew Parsons
2024-10-09 08:30:01 UTC
Reply
Permalink
Package: python3-pydata-sphinx-theme
Followup-For: Bug #1084781

As as petsc4py goes, it can just switch off use of pydata-sphinx-theme
until this bug is fixed.
Rebecca N. Palmer
2024-10-09 22:10:03 UTC
Reply
Permalink
I now have all tests passing, but using a downloaded nodejs in the
build, which is forbidden in actual packages. I am currently working on
avoiding this.
Debian Bug Tracking System
2024-10-10 21:40:02 UTC
Reply
Permalink
merge -1 1084850
Bug #1084781 [python3-pydata-sphinx-theme] pydata-sphinx-theme missing templates etc
Unable to merge bugs because:
blocks of #1084850 is '' not '1082552'
affects of #1084850 is 'src:numpy' not 'src:petsc4py'
Failed to merge 1084781: Did not alter merged bugs.
--
1084781: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1084781
1084850: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1084850
Debian Bug Tracking System
Contact ***@bugs.debian.org with problems
Rebecca N. Palmer
2024-10-11 17:30:01 UTC
Reply
Permalink
I now have it building with webpack-macros.html disabled:
https://salsa.debian.org/rnpalmer-guest/pydata-sphinx-theme/-/tree/fix1084781?ref_type=heads
However, I don't know how much functionality this loses (beyond that
only test_translations fails). Hence, I don't know whether the best
option is this incomplete 0.15, going back to 0.7 (again), or not using
this theme at all. (I chose not using this theme at all for my latest
pandas upload, but mostly because it was the one I could do right now.)

I didn't manage to get webpack to find the installed Javascript packages
(see the history of the above branch for what I tried). Notes for any
future attempt:
- Some other packages successfully use webpack (
https://codesearch.debian.net/search?q=%28%5E%7C%5B+%2C%5D%29webpack+path%3Adebian%2Fcontrol&literal=0
), so looking at them and/or using pkg-js-tools might help. However, no
other Debian package appears to use sphinx-theme-builder or nodeenv
(heat-dashboard and masakari-dashboard say they build-depend on nodeenv
but don't appear to actually run it).
- I suspect the error message
"/builds/rnpalmer-guest/pydata-sphinx-theme/debian/output/source_dir/src/node_modules
doesn't exist or is not a directory" isn't actually accurate; it appears
to come from
https://sources.debian.org/src/node-enhanced-resolve/5.15.0-1/lib/ModulesInHierarchicalDirectoriesPlugin.js/?hl=75#L75,
so adding some debug prints there might be a good investigation method.

We would probably also need to package some more Javascript modules:
node-sass (RFP #998024; that suggests that rsass or node-node-sass
*might* be an alternative), node-sass-loader, and newer versions of
libjs-popper.js and node-mini-css-extract-plugin.
Rebecca N. Palmer
2024-10-17 07:20:01 UTC
Reply
Permalink
Probably neither of those are the actual problem - my attempt disabled
css-minimizer-webpack-plugin and changed the expected node_version,
which avoided both of those issues, but there were other unrelated(?)
problems:
https://salsa.debian.org/rnpalmer-guest/pydata-sphinx-theme/-/commit/e6f035a2745dc7cb9cc9d341f183b8475693f22c
Loading...