Discussion:
Bug#980607: netcfg: FTBFS: test/test_inet_mton.c:12:15: error: too many arguments for format [-Werror=format-extra-args]
Add Reply
Lucas Nussbaum
2021-01-20 20:40:01 UTC
Reply
Permalink
Source: netcfg
Version: 1.169
Severity: serious
Justification: FTBFS on amd64
Tags: bullseye sid ftbfs
Usertags: ftbfs-20210120 ftbfs-bullseye

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.
cc -c -W -Wall -Werror -DNDEBUG -DNETCFG_VERSION="\"1.169\"" -I. -DWIRELESS -DNM -Os -fomit-frame-pointer -o test/test_inet_mton.o test/test_inet_mton.c
In file included from test/srunner.h:1,
test/test_inet_mton.c:12:15: error: too many arguments for format [-Werror=format-extra-args]
12 | "Mask address wasn't 24 bits");
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/test_inet_mton.c:24:15: error: too many arguments for format [-Werror=format-extra-args]
24 | "Mask address wasn't 22 bits");
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/test_inet_mton.c:38:15: error: too many arguments for format [-Werror=format-extra-args]
38 | "Mask address wasn't 64 bits");
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/test_inet_mton.c:52:15: error: too many arguments for format [-Werror=format-extra-args]
52 | "Mask address wasn't 60 bits");
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:60: test/test_inet_mton.o] Error 1
The full build log is available from:
http://qa-logs.debian.net/2021/01/20/netcfg_1.169_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with me
so that we can identify if something relevant changed in the meantime.

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.
Debian Bug Tracking System
2021-02-10 08:50:01 UTC
Reply
Permalink
tag -1 + patch upstream
Bug #980607 [src:netcfg] netcfg: FTBFS: test/test_inet_mton.c:12:15: error: too many arguments for format [-Werror=format-extra-args]
Added tag(s) upstream and patch.
--
980607: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=980607
Debian Bug Tracking System
Contact ***@bugs.debian.org with problems
Cyril Brulebois
2021-02-10 17:00:02 UTC
Reply
Permalink
Hallo Dennis,
Control: tag -1 + patch upstream
The attached patches allowed me to build netcfg 1.169 again, at least
on amd64.
Thanks for your patches. Any chance I could trick you into pushing a
branch somewhere? Patches fail to apply locally, and I'd rather avoid
having to fix them up (possibly breaking things in the process).

The git repository is located here:
https://salsa.debian.org/installer-team/netcfg

Thanks in advance!


Cheers,
--
Cyril Brulebois (***@debian.org) <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant
Bart Martens
2021-02-20 19:00:02 UTC
Reply
Permalink
Dennis, Cyril,

Downloading the patches from the bts works fine. The patches can be applied
with ignoring whitespaces (option -l). The patches solve the FTBFS.

| (sid)***@carolus:~/src/sponsoring/netcfg-1.169$ patch -l -p1 < ../netcfg_1.169-fix-CheckAPI.patch
| patching file test/test_nc_v6_interface_configured.c
| patching file test/test_netcfg_gateway_reachable.c
| patching file test/test_inet_ptom.c
| patching file test/test_netcfg_network_address.c
| patching file test/test_inet_mton.c
| patching file test/test_netcfg_parse_cidr_address.c
| patching file test/srunner.c
| (sid)***@carolus:~/src/sponsoring/netcfg-1.169$ patch -l -p1 < ../netcfg_1.169-fix-strncpy.patch
| patching file autoconfig.c
| patching file dhcp.c
| patching file netcfg-common.c

Cheers,

Bart
Francisco Vilmar Cardoso Ruviaro
2021-02-21 23:30:01 UTC
Reply
Permalink
Hello everyone,

I would like to help with this,
I reviewed the patches (thanks Dennis) and created an MR at
https://salsa.debian.org/installer-team/netcfg/-/merge_requests/5.

As Bart said, the patches solve the FTBFS.

I intend to make a delayed NMU in 7 days.

Regards,
--
Francisco Vilmar Cardoso Ruviaro <***@riseup.net>
4096R: 1B8C F656 EF3B 8447 2F48 F0E7 82FB F706 0B2F 7D00
John Paul Adrian Glaubitz
2021-02-22 00:10:01 UTC
Reply
Permalink
Post by Francisco Vilmar Cardoso Ruviaro
Hello everyone,
I would like to help with this,
I reviewed the patches (thanks Dennis) and created an MR at
https://salsa.debian.org/installer-team/netcfg/-/merge_requests/5.
As Bart said, the patches solve the FTBFS.
I intend to make a delayed NMU in 7 days.
That shouldn’t be necessary as Holger is usually very quick working on d-i issues.

If Holger isn’t available, I can merge the patch and upload the updated package.

Adrian
Debian Bug Tracking System
2021-02-22 17:30:03 UTC
Reply
Permalink
Your message dated Mon, 22 Feb 2021 17:18:58 +0000
with message-id <E1lEErK-0009oa-***@fasolo.debian.org>
and subject line Bug#980607: fixed in netcfg 1.171
has caused the Debian Bug report #980607,
regarding netcfg: FTBFS: test/test_inet_mton.c:12:15: error: too many arguments for format [-Werror=format-extra-args]
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ***@bugs.debian.org
immediately.)
--
980607: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=980607
Debian Bug Tracking System
Contact ***@bugs.debian.org with problems
Loading...