Discussion:
Processed: firehol: FTBFS: dh_auto_test: error: make -j1 check VERBOSE=1 returned exit code 2
Add Reply
Debian Bug Tracking System
2021-02-14 19:10:01 UTC
Reply
Permalink
tag -1 moreinfo confirmed
Bug #982719 [src:firehol] firehol: FTBFS: dh_auto_test: error: make -j1 check VERBOSE=1 returned exit code 2
Added tag(s) confirmed and moreinfo.
--
982719: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=982719
Debian Bug Tracking System
Contact ***@bugs.debian.org with problems
Jerome BENOIT
2021-02-21 13:30:01 UTC
Reply
Permalink
Dear Paul Gevers,

please consider to tag #982719 as bullseye-ignore
given that the issue is not a package issue but
it seems rather related to an chroot issue.

Best regards,
Jerome
Paul Gevers
2021-02-21 18:40:01 UTC
Reply
Permalink
Hi,
Post by Jerome BENOIT
please consider to tag #982719 as bullseye-ignore
given that the issue is not a package issue but
it seems rather related to an chroot issue.
A fresh upload from mere hours ago built successfully on our buildd
infrastructure with
Kernel: Linux 4.19.0-14-amd64 #1 SMP Debian 4.19.171-2 (2021-01-30)
amd64 (x86_64)

Does that mean this bug is not yet fully understood? (Or did I miss
details, I didn't read the bug in *full* detail.)

Paul
Lucas Nussbaum
2021-02-21 21:30:01 UTC
Reply
Permalink
Hi,

I tried again to build the version of the package that was failing
(3.1.6+ds-10) and it built *successfully* in an environment similar to
the one I used for the initial test (except it was updated to the
current state of unstable).

In the failed build log, there was:
Making check in tests
make[2]: Entering directory '/<<PKGBUILDDIR>>/tests'
make check-local
make[3]: Entering directory '/<<PKGBUILDDIR>>/tests'
./unittest ./firehol ./fireqos ./link-balancer ./update-ipsets ./vnetbuild
unshare: unshare failed: Operation not permitted
make[3]: *** [Makefile:588: check-local] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/tests'
make[2]: *** [Makefile:471: check-am] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>/tests'
make[1]: *** [Makefile:447: check-recursive] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_test: error: make -j1 check VERBOSE=1 returned exit code 2
make: *** [debian/rules:8: binary] Error 25

In the successful log, there's:
Making check in tests
make[2]: Entering directory '/<<PKGBUILDDIR>>/tests'
make check-local
make[3]: Entering directory '/<<PKGBUILDDIR>>/tests'
echo "Unprivileged user namespaces not enabled - not running tests"
Unprivileged user namespaces not enabled - not running tests
make[3]: Leaving directory '/<<PKGBUILDDIR>>/tests'
make[2]: Leaving directory '/<<PKGBUILDDIR>>/tests'
make[2]: Entering directory '/<<PKGBUILDDIR>>'
make[2]: Nothing to be done for 'check-am'.
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'

I don't understand why, in the failing build, the userns were detected
as being enabled. It might be that another package (built previously)
was enabling them during build (or during installation of one of its
build-depends). But I find that surprising, given all builds are
performed as an unprivileged user...

In any case, I can confirm that setting
/proc/sys/kernel/unprivileged_userns_clone to 1 makes the failure
reproducible (still on a 4.19 kernel). And 3.1.7+ds-1 is also affected.

Lucas
Dennis Filder
2021-02-23 17:50:02 UTC
Reply
Permalink
I just noticed that firehol has no autopkgtests yet, but since
ci.debian.net can run those under LXC/qemu instead of chroot this
would allow for the test suite to run. It might however be a bit of a
challenge to set that up at home if troubleshooting is needed.

Copying the one for root-unittests from firewalld seems like a good
starting point:
https://salsa.debian.org/utopia-team/firewalld/-/blob/debian/master/debian/tests/control

The maintainer apparently faced a similar problem and disabled the
test suite for buildd builds:
https://salsa.debian.org/utopia-team/firewalld/-/commit/d24a8b8b5b29708c811bcad4b9885d1665875aca
Maybe he'll be willing to help with setting this up.

The autopkgtest probably will have to specify "needs-root" to set
unprivileged_userns_clone=1 (unless the VM image already has that set
up), but the test suite itself needn't run as root.

Regards,
Dennis.
Jerome BENOIT
2021-02-25 11:10:02 UTC
Reply
Permalink
Dear Dennis, thanks for your reply.
I was rather wondering if setting Rules-Requires-Root to yes in d/rules
will ask to bbuild to act as "needs-root" for autopkgtest.
Jerome
Debian Bug Tracking System
2021-02-28 09:40:01 UTC
Reply
Permalink
Your message dated Sun, 28 Feb 2021 09:33:29 +0000
with message-id <E1lGIS9-000CKL-***@fasolo.debian.org>
and subject line Bug#982719: fixed in firehol 3.1.7+ds-2
has caused the Debian Bug report #982719,
regarding firehol: FTBFS: dh_auto_test: error: make -j1 check VERBOSE=1 returned exit code 2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ***@bugs.debian.org
immediately.)
--
982719: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=982719
Debian Bug Tracking System
Contact ***@bugs.debian.org with problems
Loading...