Bug#1085153: rrdtool: FTBFS on armel and armhf: passing argument 2 of ‘_sql_fetchrow’ from incompatible pointer type

[Niko Tyni]

Source: rrdtool
Version: 1.7.2-4.1
Severity: serious

This package failed to build against Perl 5.40 on armhf and armel.

https://buildd.debian.org/status/package.php?p=rrdtool

Looks like a time64 related thing that was already warning earlier but
has now become a hard error. Presumably that changed with GCC-14 ?


rrd_fetch_libdbi.c:625:45: error: passing argument 2 of ‘_sql_fetchrow’ from incompatible pointer type [-Wincompatible-pointer-types]
625 | while((r_status=_sql_fetchrow(&table_help,&r_timestamp,&r_value,derive))>0) {
| ^~~~~~~~~~~~
| |
| long int *
rrd_fetch_libdbi.c:220:62: note: expected ‘time_t *’ {aka ‘long long int *’} but argument is of type ‘long int *’
220 | static int _sql_fetchrow(struct sql_table_helper* th,time_t *timestamp, rrd_value_t *value,int ordered) {
| ~~~~~~~~^~~~~~~~~
make[4]: *** [Makefile:1006: librrd_la-rrd_fetch_libdbi.lo] Error 1

[gregor herrmann]

Post by Niko Tyni
This package failed to build against Perl 5.40 on armhf and armel.
https://buildd.debian.org/status/package.php?p=rrdtool
Looks like a time64 related thing that was already warning earlier but
has now become a hard error. Presumably that changed with GCC-14 ?
rrd_fetch_libdbi.c:625:45: error: passing argument 2 of ‘_sql_fetchrow’ from incompatible pointer type [-Wincompatible-pointer-types]
625 | while((r_status=_sql_fetchrow(&table_help,&r_timestamp,&r_value,derive))>0) {
| ^~~~~~~~~~~~
| |
| long int *
rrd_fetch_libdbi.c:220:62: note: expected ‘time_t *’ {aka ‘long long int *’} but argument is of type ‘long int *’
220 | static int _sql_fetchrow(struct sql_table_helper* th,time_t *timestamp, rrd_value_t *value,int ordered) {
| ~~~~~~~~^~~~~~~~~
make[4]: *** [Makefile:1006: librrd_la-rrd_fetch_libdbi.lo] Error 1

Friendly ping: Is one of the maintainers in the situation to do an
upload with the upstream commit [0] shortly? Otherwise I'm happy to
help with an NMU.

(This is one of a handful blockers for the Perl 5.40 transition.)

Cheers,
gregor

[0] https://github.com/oetiker/rrdtool-1.x/pull/1265 or
https://github.com/oetiker/rrdtool-1.x/pull/1265/commits/5f954c9aa84420dca3c05caea5feb0f918d6bc47